[ 
https://issues.apache.org/jira/browse/HCATALOG-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215954#comment-13215954
 ] 

[email protected] commented on HCATALOG-239:
--------------------------------------------------------



bq.  On 2012-02-24 17:52:26, Francis Liu wrote:
bq.  > trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java, line 39
bq.  > <https://reviews.apache.org/r/3945/diff/2-3/?file=85630#file85630line39>
bq.  >
bq.  >     you can already clean this up. the output part is gone.
bq.  
bq.  Sushanth Sowmyan wrote:
bq.      This will be cleaned up as part of Daniel's patch removing ISD/OSD 
info. It's best to leave this here for now, since further tests that check for 
its existence still need to be changed.

This code doesn't really do anything. If Daniel's working on removing this I 
don't mind, I'm just worried it's gonna be forgotten.


- Francis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3945/#review5327
-----------------------------------------------------------


On 2012-02-24 21:00:23, Vikram Dixit Kumaraswamy wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3945/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-24 21:00:23)
bq.  
bq.  
bq.  Review request for Sushanth Sowmyan and Francis Liu.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Incorporated Francis' comments.
bq.  
bq.  
bq.  This addresses bug HCATALOG-239.
bq.      https://issues.apache.org/jira/browse/HCATALOG-239
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/src/java/org/apache/hcatalog/common/ErrorType.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/data/DataType.java 1293367 
bq.    
trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java 1293367 
bq.    
trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
 1293367 
bq.    
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java 
1293367 
bq.    
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 
1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InternalUtil.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java 1293367 
bq.    trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1293367 
bq.    trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java 1293367 
bq.    trunk/src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java 1293367 
bq.    
trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java 
1293367 
bq.    trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java 
1293367 
bq.    trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java 
1293367 
bq.  
bq.  Diff: https://reviews.apache.org/r/3945/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Vikram
bq.  
bq.


                
> Changes to HCatInputFormat to make it use SerDes instead of StorageDrivers
> --------------------------------------------------------------------------
>
>                 Key: HCATALOG-239
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-239
>             Project: HCatalog
>          Issue Type: Sub-task
>          Components: storage handlers
>    Affects Versions: 0.4
>            Reporter: Alan Gates
>            Assignee: Vikram Dixit K
>             Fix For: 0.4
>
>         Attachments: 239.patch, 239_1.patch, 239_2.patch, 239_3.patch, 
> 239_4.patch, 239_5.patch, 239_6.patch, 239_7.patch, 239_8.patch
>
>
> This JIRA covers changes to HCatInputFormat and InputJobInfo.  See 
> HCATALOG-237 for details and design notes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to