[ 
https://issues.apache.org/jira/browse/HCATALOG-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223775#comment-13223775
 ] 

jirapos...@reviews.apache.org commented on HCATALOG-282:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4205/
-----------------------------------------------------------

Review request for Alan Gates and Francis Liu.


Summary
-------

Removing Serializable from FosterStorageHandler (and as a result, removing the 
storageHandler object from PartInfo)


This addresses bug HCATALOG-282.
    https://issues.apache.org/jira/browse/HCATALOG-282


Diffs
-----

  /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1297783 
  /trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java 
1297783 
  /trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java 
1297783 
  /trunk/src/java/org/apache/hcatalog/mapreduce/PartInfo.java 1297783 

Diff: https://reviews.apache.org/r/4205/diff


Testing
-------


Thanks,

Sushanth


                
> HCatInputFormat shouldn't expect storageHandler to be serializable
> ------------------------------------------------------------------
>
>                 Key: HCATALOG-282
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-282
>             Project: HCatalog
>          Issue Type: Sub-task
>            Reporter: Francis Liu
>            Assignee: Sushanth Sowmyan
>             Fix For: 0.4
>
>         Attachments: HCATALOG-282.patch
>
>
> HCatInputFormat shouldn't expect storageHandler to be serializable. 
> HCatStorageHandler is part of PartInfo which is serializable. The 
> storageHandler shouldn't be serializable as the base interface 
> HiveStorageHandler is not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to