----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4732/#review7422 -----------------------------------------------------------
Ship it! some small changes, but this can be changed on commit. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java <https://reviews.apache.org/r/4732/#comment16351> is this missing an "{}"? /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java <https://reviews.apache.org/r/4732/#comment16352> I'd prefer the exception be passed to the logger instead of the exception message being printed. - Francis On 2012-04-30 20:51:07, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4732/ > ----------------------------------------------------------- > > (Updated 2012-04-30 20:51:07) > > > Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas. > > > Summary > ------- > > We need to do the following things: > > + Use log4j across the board > + Introduce a class with methods to help logging, refactoring away the bunch > of these functions in HCatUtil right now > + Instrument debug logging with isLogEnabled checks on the log level > + remove all instances of commented code whose purpose was for debug logs > > > This addresses bug hcatalog-68. > https://issues.apache.org/jira/browse/hcatalog-68 > > > Diffs > ----- > > /trunk/ivy.xml 1332376 > /trunk/src/java/org/apache/hcatalog/cli/HCatCli.java 1332376 > > /trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java > 1332376 > /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1332376 > /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java > 1332376 > > /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java > 1332376 > /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1332376 > /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1332376 > > /trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java > 1332376 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 1332376 > /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1332376 > /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1332376 > /trunk/src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java > 1332376 > /trunk/src/test/org/apache/hcatalog/cli/TestPermsGrp.java 1332376 > /trunk/src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java 1332376 > /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1332376 > /trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java 1332376 > /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1332376 > /trunk/src/test/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java > 1332376 > /trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java > 1332376 > > /trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java > 1332376 > /trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java > 1332376 > /trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java > 1332376 > > /trunk/src/test/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java > 1332376 > > Diff: https://reviews.apache.org/r/4732/diff > > > Testing > ------- > > Unit tests pass. Log messages verified from test logs. > > > Thanks, > > Vandana > >
