----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4971/#review7816 -----------------------------------------------------------
Looks good to me. Just a concern with the change in the test output directory. If you agree with any of my proposals, I can change that on commit. Will run e2e tests. src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java <https://reviews.apache.org/r/4971/#comment17147> The warehouse directory is set in the ant test target. If you're doing this for runs in your IDE then it'd be better to have this check if the sysproperty hive.metastore.warehouse.dir is set to support both cases. It'll probably better if you put the dir in /tmp similar to ant the config "/tmp/hcat_junit_warehouse". Or add ant into the name {user.home}/hive_build/... - Francis On 2012-05-05 01:23:50, Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4971/ > ----------------------------------------------------------- > > (Updated 2012-05-05 01:23:50) > > > Review request for hcatalog and Francis Liu. > > > Summary > ------- > > Update ProgressReporter to work with both old and new mapreduce API. Delay > creating the base record reader so we have a StatusReporter and can use > counters. > > > This addresses bug HCATALOG-373. > https://issues.apache.org/jira/browse/HCATALOG-373 > > > Diffs > ----- > > src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java 268167e > src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 65f96f4 > src/java/org/apache/hcatalog/mapreduce/InternalUtil.java 1837081 > src/java/org/apache/hcatalog/mapreduce/ProgressReporter.java fb379cd > src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java f3d07a0 > > Diff: https://reviews.apache.org/r/4971/diff > > > Testing > ------- > > "ant clean test" passes > > I can run pig+hcatalog queries using Elephant-Bird deprecated API wrappers, > which is why this issue originally came up. > > > Thanks, > > Travis > >
