----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5496/#review8484 -----------------------------------------------------------
I am a maven person. My knowledge of ant and ivy is very minimal and just copy-paste. So I will leave it to the ant experts to review it. Just had one comment. http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/build.xml <https://reviews.apache.org/r/5496/#comment18159> Do we want to do ivy-publish inside the jar target. Would prefer it to be called separately in only apache hudson build. ivy-publish can probably depend on jar. All of us run jar in our hosts. Putting ivy-publish here might lead to issues. - Rohini Palaniswamy On June 22, 2012, 3:45 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5496/ > ----------------------------------------------------------- > > (Updated June 22, 2012, 3:45 p.m.) > > > Review request for hcatalog. > > > Description > ------- > > Update HCatalog build to package pig classes as a separate jar. I did not > update ivy yet, but if the general approach looks good I will update. This > will let the core hcatalog.jar depends only on stuff needed by all processing > frameworks; then people that want to use pig can use the pig adapter which > has the pig dependency. > > I believe we'll have more adapters in the future, so I'm trying to make this > reusable. > > For example: > > Traviss-iMac:hcatalog travis$ jar -tvf > hcatalog-pig-adapter/build/hcatalog-pig-adapter-0.5.0-dev.jar > 0 Thu Jun 21 10:34:18 PDT 2012 META-INF/ > 107 Thu Jun 21 10:34:16 PDT 2012 META-INF/MANIFEST.MF > 0 Thu Jun 21 10:34:16 PDT 2012 org/ > 0 Thu Jun 21 10:34:16 PDT 2012 org/apache/ > 0 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/ > 0 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/pig/ > 0 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/pig/drivers/ > 4352 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/HCatBaseLoader.class > 1261 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/HCatBaseStorer$1.class > 12413 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/HCatBaseStorer.class > 632 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/pig/HCatLoader$1.class > 8518 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/pig/HCatLoader.class > 6801 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/pig/HCatStorer.class > 1019 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/PigHCatUtil$1.class > 13117 Thu Jun 21 10:34:16 PDT 2012 org/apache/hcatalog/pig/PigHCatUtil.class > 3711 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/drivers/LoadFuncBasedInputFormat$LoadFuncBasedRecordReader.class > 2383 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/drivers/LoadFuncBasedInputFormat.class > 2189 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/drivers/StoreFuncBasedOutputFormat$StoreFuncBasedOutputCommitter.class > 1775 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/drivers/StoreFuncBasedOutputFormat$StoreFuncBasedRecordWriter.class > 2647 Thu Jun 21 10:34:16 PDT 2012 > org/apache/hcatalog/pig/drivers/StoreFuncBasedOutputFormat.class > Traviss-iMac:hcatalog travis$ > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/build-common-new.xml > PRE-CREATION > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/build.xml 1352540 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/hcatalog-pig-adapter/build.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/hcatalog-pig-adapter/ivy.xml > PRE-CREATION > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/ivy.xml 1352540 > > Diff: https://reviews.apache.org/r/5496/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
