> On April 28, 2012, 12:32 a.m., Alan Gates wrote: > > trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java, line 63 > > <https://reviews.apache.org/r/4921/diff/1/?file=105168#file105168line63> > > > > These comments dont't seem to match this function.
Changed the description of writeExternal(ObjectOutput out) from "Save the WriterContext contents" to "Write the configuration to an external location." > On April 28, 2012, 12:32 a.m., Alan Gates wrote: > > trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java, line 71 > > <https://reviews.apache.org/r/4921/diff/1/?file=105168#file105168line71> > > > > These comments don't seem to match this function. Changed the description of readExternal(ObjectInput in) from "Restore the WriterContext contents" to "Restore the contents of this WriterContext with data read from an external location." - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4921/#review7339 ----------------------------------------------------------- On April 28, 2012, 12:13 a.m., Alan Gates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4921/ > ----------------------------------------------------------- > > (Updated April 28, 2012, 12:13 a.m.) > > > Review request for hcatalog. > > > Description > ------- > > Javadoc improvements > > > This addresses bug HCATALOG-381. > https://issues.apache.org/jira/browse/HCATALOG-381 > > > Diffs > ----- > > trunk/src/java/org/apache/hcatalog/data/HCatRecord.java 1311550 > trunk/src/java/org/apache/hcatalog/data/HCatRecordable.java 1311550 > trunk/src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java 1311550 > trunk/src/java/org/apache/hcatalog/data/schema/HCatSchema.java 1311550 > trunk/src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/EntityBase.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/ReadEntity.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/ReaderContext.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/WriteEntity.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/WriterContext.java 1311550 > trunk/src/java/org/apache/hcatalog/data/transfer/state/StateProvider.java > 1311550 > > Diff: https://reviews.apache.org/r/4921/diff/ > > > Testing > ------- > > > Thanks, > > Alan Gates > >
