----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5891/#review9041 -----------------------------------------------------------
Why put the findbugs macro in a new file? Why not add it to build-common-new.xml instead? - Alan Gates On July 10, 2012, 7:12 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5891/ > ----------------------------------------------------------- > > (Updated July 10, 2012, 7:12 p.m.) > > > Review request for hcatalog and Alan Gates. > > > Description > ------- > > Update HCatalog build to run findbugs against the core and pig adapter > subprojects. > > > This addresses bug HCATALOG-447. > https://issues.apache.org/jira/browse/HCATALOG-447 > > > Diffs > ----- > > ant/findbugs.xml PRE-CREATION > build-common-new.xml 54c54c4 > build.xml f278998 > hcatalog-pig-adapter/build.xml 269562f > hcatalog-pig-adapter/ivy.xml 1f41ff8 > > Diff: https://reviews.apache.org/r/5891/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
