[ 
https://issues.apache.org/jira/browse/HCATALOG-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414308#comment-13414308
 ] 

Rohini Palaniswamy commented on HCATALOG-448:
---------------------------------------------

Good catch Rajesh. Patch looks good. Just two minor things

1) You have already removed localContext = 
HCatMapRedUtil.createTaskAttemptContext(context);. Can you also remove the 
declaration as it is not used anymore.
{code}
org.apache.hadoop.mapred.TaskAttemptContext localContext;
{code}
2) I think you made a unintentional change or it was from a older version of 
the file. You might want to revert it back. 
{code}
-     * @return the storagehandler
+     * @return the storageDriver
{code}

Can you post the updated patch in reviewboard? It is more easy to review there.
                
> HCatStorer performance is 4x slower in HCat 0.4 than HCat 0.2
> -------------------------------------------------------------
>
>                 Key: HCATALOG-448
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-448
>             Project: HCatalog
>          Issue Type: Bug
>    Affects Versions: 0.4.1
>            Reporter: Rohini Palaniswamy
>            Assignee: Mithun Radhakrishnan
>            Priority: Critical
>         Attachments: hcatalog-448-for-0.4-codebase.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to