[ 
https://issues.apache.org/jira/browse/HCATALOG-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426681#comment-13426681
 ] 

Travis Crawford commented on HCATALOG-402:
------------------------------------------

Hey David, I just looked at this patch and agree there's a lot of overlap 
between {{TestMsgBusConnection}} and {{TestNotificationListener}}, and that 
{{TestNotificationListener}} tests a superset.

I haven't experienced this test being flakey though - can you elaborate on the 
issue you're seeing? There are some differences between how message bus 
connections are established between the two tests, so perhaps we need to 
standardize that.
                
> Notification tests both do the same thing
> -----------------------------------------
>
>                 Key: HCATALOG-402
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-402
>             Project: HCatalog
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.4, 0.5, 0.4.1
>            Reporter: David Capwell
>         Attachments: HCATALOG-402.patch
>
>
> We have two notification tests: TestNotificationListener, and 
> TestMsgBusConnection.  Both of them seem to do the same thing 
> (TestNotificationListener does more) and the msg buss seems to hang from time 
> to time.  Can we merge the two and just have TestNotificationListener?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to