[
https://issues.apache.org/jira/browse/HCATALOG-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426885#comment-13426885
]
Travis Crawford commented on HCATALOG-272:
------------------------------------------
In general this looks good, but these are hard to get right the first time.
Some suggestions:
* Update to junit4 style test, which is a bit nicer to work with.
* Check in actual JSON data as test resources, and read the records,
deserialize them, serialize them, write them back out & compare. Inevitably
we're going to find some case this doesn't handle correctly and I think setting
ourselves up to fix it quickly when we find that case is important. When a user
reports an error we simply ask them for the record that doesn't work, paste it
into the test data file, and make the test pass.
Thanks for generalizing this! Seeing how there are multiple independent json
serde implementations already getting this into Hive will be a useful update
for a lot of people.
> HCat's JSONSerDe should be moved from HCat to Hive
> --------------------------------------------------
>
> Key: HCATALOG-272
> URL: https://issues.apache.org/jira/browse/HCATALOG-272
> Project: HCatalog
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Sushanth Sowmyan
> Attachments: hive-json-serde.patch
>
>
> Ideally this should be placed in Hive so Hive users can benefit from it as
> well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
