----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4940/#review10056 -----------------------------------------------------------
Ship it! Looks good. Minor fix which can be changed on commit. /trunk/webhcat/java-client/ivy.xml <https://reviews.apache.org/r/4940/#comment21282> some if not all if these are transitive dependencies to hcatalog-core, so you don't need to specify those. - Francis Liu On Aug. 8, 2012, 10:21 p.m., Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4940/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 10:21 p.m.) > > > Review request for hcatalog, Ashutosh Chauhan, Thejas Nair, Alan Gates, > Francis Liu, David Capwell, and Rohini Palaniswamy. > > > Description > ------- > > HCatalog java APIs for DDL commands. > > > This addresses bug hcatalog-419. > https://issues.apache.org/jira/browse/hcatalog-419 > > > Diffs > ----- > > /trunk/build.xml 1369895 > /trunk/webhcat/java-client/build.xml PRE-CREATION > /trunk/webhcat/java-client/ivy.xml PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/ConnectionFailureException.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatAddPartitionDesc.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClient.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatClientHMSImpl.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatCreateDBDesc.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatCreateTableDesc.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatDatabase.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatPartition.java > PRE-CREATION > > /trunk/webhcat/java-client/src/main/java/org/apache/hcatalog/api/HCatTable.java > PRE-CREATION > > /trunk/webhcat/java-client/src/test/java/org/apache/hcatalog/api/TestHCatClient.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4940/diff/ > > > Testing > ------- > > Unit test passes. > > TODO: > > - cover more test cases. > - E2E tests. > > > Thanks, > > Vandana Ayyalasomayajula > >
