----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6644/#review10360 -----------------------------------------------------------
Ship it! two minor comments, fixes to these don't need extra review. src/java/org/apache/hcatalog/common/HCatConstants.java <https://reviews.apache.org/r/6644/#comment21982> i'd still like this to be a javadoc comment. src/java/org/apache/hcatalog/data/HCatRecordSerDe.java <https://reviews.apache.org/r/6644/#comment21983> field instanceof Boolean ? - Dmitriy Ryaboy On Aug. 15, 2012, 6:58 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6644/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 6:58 p.m.) > > > Review request for hcatalog and Dmitriy Ryaboy. > > > Description > ------- > > Add support for boolean-to-integer conversions, driven by a global > HCatContext. > > Please see https://issues.apache.org/jira/browse/HCATALOG-460 for details. > > > This addresses bug HCATALOG-460. > https://issues.apache.org/jira/browse/HCATALOG-460 > > > Diffs > ----- > > hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatLoader.java > ac7ef6b > > hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestHCatLoader.java > 44aac3a > src/java/org/apache/hcatalog/common/HCatConstants.java 01d6267 > src/java/org/apache/hcatalog/common/HCatContext.java PRE-CREATION > src/java/org/apache/hcatalog/data/HCatRecordSerDe.java ec9b8c5 > src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java 077bbf9 > > Diff: https://reviews.apache.org/r/6644/diff/ > > > Testing > ------- > > Added test & all tests pass. > > CI: https://travis.ci.cloudbees.com/job/HCATALOG-460_boolean_to_int/ > > > Thanks, > > Travis Crawford > >
