----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6647/#review10385 -----------------------------------------------------------
looks good overall. src/java/org/apache/hcatalog/data/HCatRecordSerDe.java <https://reviews.apache.org/r/6647/#comment22094> wrong default? src/java/org/apache/hcatalog/data/HCatRecordSerDe.java <https://reviews.apache.org/r/6647/#comment22095> wrong default? - Dmitriy Ryaboy On Aug. 16, 2012, 1 a.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6647/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 1 a.m.) > > > Review request for hcatalog. > > > Description > ------- > > Add support to read/write smallint/tinyint columns from the pig adapter. > > > This addresses bug HCATALOG-425. > https://issues.apache.org/jira/browse/HCATALOG-425 > > > Diffs > ----- > > > hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatBaseStorer.java > dc9d005 > hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatLoader.java > 28d860b > hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatStorer.java > 2bb94e6 > hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/PigHCatUtil.java > dee0f74 > > hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestHCatLoaderStorer.java > PRE-CREATION > src/java/org/apache/hcatalog/common/HCatConstants.java b0f6f70 > src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 6d6bf3e > src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java 3292a6f > src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java 463ad41 > > Diff: https://reviews.apache.org/r/6647/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
