----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6678/#review10472 -----------------------------------------------------------
Ship it! Ship It! - Dmitriy Ryaboy On Aug. 17, 2012, 5:50 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6678/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 5:50 p.m.) > > > Review request for hcatalog. > > > Description > ------- > > This patch updates the HCatalog read path to expect a Deserializer, rather > than a full SerDe. This is a no-op for anyone who could already read; > however, now Deserializer-only serde's work. A test is added for > ThriftDeserializer that checks both the schema is correct, and data is read > correctly. > > > This addresses bug HCATALOG-472. > https://issues.apache.org/jira/browse/HCATALOG-472 > > > Diffs > ----- > > src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 99bebc5 > src/java/org/apache/hcatalog/mapreduce/InternalUtil.java fa78a61 > src/test/org/apache/hcatalog/mapreduce/TestHCatHiveThriftCompatibility.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6678/diff/ > > > Testing > ------- > > https://travis.ci.cloudbees.com/job/HCATALOG-472_deserializer/ > > > Thanks, > > Travis Crawford > >
