[
https://issues.apache.org/jira/browse/HCATALOG-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Crawford updated HCATALOG-486:
-------------------------------------
Attachment: HCATALOG-486_checkstyle.1.patch
This patch adds checkstyle support for to the HCatalog build, and enforces a
small number of policies; if a policy is violated (unusued import for example)
the build will fail, providing the developer with a file, line number, and rule
that was violated.
Additionally, the hbase storage driver was migrated from ivy to the maven ant
tasks. I did this because of build issues on CI, and this resolved the issue I
was having. It also moves us closer to using maven for our dependency & repo
management. Its actually super rad – definitely check that part out :)
> HCatalog should use checkstyle to enforce coding style
> ------------------------------------------------------
>
> Key: HCATALOG-486
> URL: https://issues.apache.org/jira/browse/HCATALOG-486
> Project: HCatalog
> Issue Type: Story
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Attachments: HCATALOG-486_checkstyle.1.patch
>
>
> Currently HCatalog uses a variety of coding styles, making it very
> challenging to configure an editor for format code correctly, and making it
> harder to read/maintain than necessary.
> Checkstyle is an open-source tool for checking source code against a style
> policy, which when integrated with the build allows one to enforce the policy.
> Of course, there's a delicate balance between imposing a convention vs.
> allowing developers to solve problems in their own way, and we need to be
> cognizant of that balance.
> I think we should integrate checkstyle with our build, initially with a set
> of policies I think are pretty obvious: basically stuff like no unused
> imports, and no ridiculously long files. Over time we can define new
> policies, and cleanup the code to match, knowing that that particular issue
> won't sneak back in.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
