+1 on making indentation uniform. AFAIK indentation for HCatalog is 4 spaces. Old files had to be left at 2 to make reviewing patches easier. If we have a separate jira just to address indentation that would make things a lot easier to review. I'm just worried that this will probably make diffs in our history harder, is there a way to ignore whitespace changes?
-Francis On 9/5/12 3:57 PM, "Chris Drome" <[email protected]> wrote: >I had commented to Francis about this a couple of weeks ago. > >It seems like the Alan Gates specified 4 spaces, but some contributors are >using 2 spaces instead. > > >On 9/5/12 3:55 PM, "Arup Malakar" <[email protected]> wrote: > >>Hi, >> >>I see that some of the classes (~81 classes) in the codebase use 2 >>spaces for indentation. Rest >>of the codebase (~67 classes) use 4 spaces for indentation. Having a >>consistent coding style makes >>it easier to read as well to change the code. >> >>If we agree on having a consistent style I can create a JIRA and take >>a stab at changing the classes >>to use the same indention. Also, in that case what should be the >>standard, 2 or 4 spaces? >> >>Thanks, >>Arup >
