> On Sept. 12, 2012, 4:42 a.m., Ashutosh Chauhan wrote: > > src/java/org/apache/hcatalog/listener/NotificationListener.java, line 144 > > <https://reviews.apache.org/r/7002/diff/1/?file=152446#file152446line144> > > > > It will be good to have root-caused NPE problem of Datanucleus here, > > but that really is a topic of separate jira. For now, I will suggest to add > > a note in comment that some of the information is lost for a partition > > object that is sent over message bus. > > Travis Crawford wrote: > I thought about that but would prefer to spend any DataNucleus time > getting us on a modern version. Even if we find a small bug in DN, the > version we use is no longer maintained and getting a new release could be > challenging. > > Upgrade datanucleus from 2.0.3 to 3.0.1 > https://issues.apache.org/jira/browse/HIVE-2084
Agreed thats why I said its for a separate jira :) Adding a note in comment for now (till we upgrade DN or find some other solution for the problem) is sufficient since AFAIK no one currently relies on all this info to be present in partition object received over message bus. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7002/#review11382 ----------------------------------------------------------- On Sept. 12, 2012, 2 p.m., Travis Crawford wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7002/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2012, 2 p.m.) > > > Review request for hcatalog and Travis Crawford. > > > Description > ------- > > Fix broken TestNotificationListener. > > > This addresses bug HCATALOG-498. > https://issues.apache.org/jira/browse/HCATALOG-498 > > > Diffs > ----- > > src/java/org/apache/hcatalog/listener/NotificationListener.java 0660042 > src/test/org/apache/hcatalog/listener/TestNotificationListener.java 58ef72c > src/test/org/apache/hcatalog/mapreduce/HCatBaseTest.java 4302e67 > > Diff: https://reviews.apache.org/r/7002/diff/ > > > Testing > ------- > > > Thanks, > > Travis Crawford > >
