----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7043/#review11465 -----------------------------------------------------------
Ship it! Looks good Feng! Please upload the patch to Jira and if tests pass I'll commit. - Travis Crawford On Sept. 13, 2012, 4:15 a.m., Feng Peng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7043/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 4:15 a.m.) > > > Review request for hcatalog, Dmitriy Ryaboy and Travis Crawford. > > > Description > ------- > > We added a property called HCAT_PIG_STORER_EXTERNAL_LOCATION to the > UDFContext of HCatStorer: when the property is set AND the table type is > EXTERNAL, HCatStorer writes the data to the external path the property > specifies. > > > This addresses bug hcatalog-500. > https://issues.apache.org/jira/browse/hcatalog-500 > > > Diffs > ----- > > hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatStorer.java > c46db33 > > hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/HCatStorerWrapper.java > PRE-CREATION > > hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestHCatStorerWrapper.java > PRE-CREATION > src/java/org/apache/hcatalog/common/HCatConstants.java 626d91b > src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java > 336a3f2 > src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java 3f368d8 > > Diff: https://reviews.apache.org/r/7043/diff/ > > > Testing > ------- > > Added a corresponding unit test. Also tested on our cluster. > > > Thanks, > > Feng Peng > >
