-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7068/
-----------------------------------------------------------
(Updated Sept. 14, 2012, 5:40 p.m.)
Review request for hcatalog and Travis Crawford.
Changes
-------
Hey Travis, littering the directory with temporary file has been a pet peeve
for me too. I have incorporated HCatBaseTest to take care of that. Also see my
comment about checkOutputSpec if we can remove it.
Now regarding HCatBaseTest I have one concern:
If the child class happen to have a the setup method named as setUp() in that
case it would override the setUp() method in HCatBaseTest and the parent method
wont be called by Junit and needs to be called by
the child class. On the other hand if the child calls it the method to set up
things as initData() then both initData() and setUp() in parent would be called
by junit.
This seems a bit counter intuitive as when to call super.setUp() is dependent
on the child method name. We could solve it in two ways:
1. Make the setUp() final in HCatBaseTest so that it never could be overwritten
by mistake, causing Before to call it every time. (Unfortunately Before
annotation doesn't work with a final method) So this approach wont work.
2. Remove the Before annotation making it clear that child method is supposed
to call it/and also adding java doc.
Any other idea?
Arup
Description
-------
1. Added a test case to reproduce the bug
2. Fixed the bug
2. Apart from some cosmetic changes for readability in HCatMapReduceTest
Removed the abstract method initialize() in HCatMapReduceTest as the same
could be achieved by using the well understood method setUp()
This addresses bug HCATALOG-490.
https://issues.apache.org/jira/browse/HCATALOG-490
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
1384595
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/HCatBaseTest.java
1384595
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java
1384595
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
1384595
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatNonPartitioned.java
1384595
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatPartitioned.java
1384595
Diff: https://reviews.apache.org/r/7068/diff/
Testing
-------
test:
[mkdir] Created dir: /Users/malakar/code/oss/hcatalog/trunk/build/test/logs
[mkdir] Created dir:
/Users/malakar/code/oss/hcatalog/trunk/build/test/hcat_junit_warehouse
[junit] WARNING: multiple versions of ant detected in path for junit
[junit]
jar:file:/Users/malakar/bin/apache-ant-1.8.4/lib/ant.jar!/org/apache/tools/ant/Project.class
[junit] and
jar:file:/Users/malakar/code/oss/hcatalog/trunk/build/ivy/lib/test/ant-ant-1.6.5.jar!/org/apache/tools/ant/Project.class
[junit] Running org.apache.hcatalog.cli.TestPermsGrp
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 14.854 sec
[junit] Running org.apache.hcatalog.cli.TestSemanticAnalysis
[junit] Tests run: 22, Failures: 0, Errors: 0, Time elapsed: 20.615 sec
[junit] Running org.apache.hcatalog.cli.TestUseDatabase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 13.533 sec
[junit] Running org.apache.hcatalog.common.TestHCatUtil
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.868 sec
[junit] Running org.apache.hcatalog.common.TestHiveClientCache
[junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 38.042 sec
[junit] Shutting down hive metastore.
[junit] Running org.apache.hcatalog.data.TestDefaultHCatRecord
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.21 sec
[junit] Running org.apache.hcatalog.data.TestHCatRecordSerDe
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.181 sec
[junit] Running org.apache.hcatalog.data.TestJsonSerDe
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.239 sec
[junit] Running org.apache.hcatalog.data.TestLazyHCatRecord
[junit] Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 0.177 sec
[junit] Running org.apache.hcatalog.data.TestReaderWriter
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 5.083 sec
[junit] Running org.apache.hcatalog.data.schema.TestHCatSchema
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.007 sec
[junit] Running org.apache.hcatalog.data.schema.TestHCatSchemaUtils
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.043 sec
[junit] Running org.apache.hcatalog.listener.TestMsgBusConnection
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 7.588 sec
[junit] Running org.apache.hcatalog.listener.TestNotificationListener
[junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 8.045 sec
[junit] Test org.apache.hcatalog.listener.TestNotificationListener FAILED
[junit] Running org.apache.hcatalog.mapreduce.TestHCatDynamicPartitioned
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 122.809 sec
[junit] Running org.apache.hcatalog.mapreduce.TestHCatHiveCompatibility
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 32.425 sec
[junit] Running
org.apache.hcatalog.mapreduce.TestHCatHiveThriftCompatibility
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 11.662 sec
[junit] Running org.apache.hcatalog.mapreduce.TestHCatInputFormat
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 10.985 sec
[junit] Running org.apache.hcatalog.mapreduce.TestHCatMultiOutputFormat
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 28.85 sec
[junit] Shutting down hive metastore.
[junit] Running org.apache.hcatalog.mapreduce.TestHCatNonPartitioned
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 14.169 sec
[junit] Running org.apache.hcatalog.mapreduce.TestHCatOutputFormat
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 5.323 sec
[junit] Running org.apache.hcatalog.mapreduce.TestHCatPartitioned
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 92.827 sec
[junit] Running org.apache.hcatalog.mapreduce.TestMultiOutputFormat
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 67.213 sec
[junit] Running org.apache.hcatalog.mapreduce.TestPassProperties
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 8.611 sec
[junit] Running org.apache.hcatalog.mapreduce.TestSequenceFileReadWrite
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 53.583 sec
[junit] Running org.apache.hcatalog.rcfile.TestRCFileMapReduceInputFormat
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.216 sec
[junit] Running org.apache.hcatalog.security.TestHdfsAuthorizationProvider
[junit] Tests run: 34, Failures: 0, Errors: 0, Time elapsed: 23.476 sec
Thanks,
Arup Malakar
