-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7400/
-----------------------------------------------------------
Review request for hcatalog and Francis Liu.
Description
-------
Remove two unused arguments from HCatalogHadoopShims.commitJob. One of the
removed arguments is ResourceSchema which comes from pig, and as currently
structured requires pig be a dependency of hcatalog-core, which we do not want.
Update dependencies so Pig is no longer a dependency of hcatalog-core. This is
important because currently all HCatalog users, even if they do not use pig at
all, get that dependency and its transitive deps. As a library we hope many
other projects will use its important our dependencies be as thin as possible.
This addresses bug HCATALOG-522.
https://issues.apache.org/jira/browse/HCATALOG-522
Diffs
-----
hcatalog-pig-adapter/src/main/java/org/apache/hcatalog/pig/HCatStorer.java
848b2fb
ivy.xml 3ddab03
server-extensions/pom.xml ee974ad
shims/ivy.xml 773d094
shims/src/20/java/org/apache/hcatalog/shims/HCatHadoopShims20S.java 5deea06
shims/src/23/java/org/apache/hcatalog/shims/HCatHadoopShims23.java 80d2042
src/java/org/apache/hcatalog/shims/HCatHadoopShims.java ee693b4
Diff: https://reviews.apache.org/r/7400/diff/
Testing
-------
As far as I can tell this is a no-op because the removed parameters were not
actually used. I also ran the tests:
https://travis.ci.cloudbees.com/job/HCATALOG-522_remove_pig_from_core/2/console
Thanks,
Travis Crawford
