Great question. I mailed the list about basically the same thing over the weekend.
http://mail-archives.apache.org/mod_mbox/incubator-hcatalog-dev/201210.mbox/%3CCABN7xTBzm7MuSGV%3DO%3D8piSJ5Ke1rTr6rT4tpS2cF_1MOrq8dEA%40mail.gmail.com%3E The classes & packages you highlighted are very confusing, because its unclear if they're still in use, if they actually work, if they don't work but should, etc. Its very confusing. 1) org.apache.hcatalog.rcfile.RCFileMapReduceOutputFormat - I don't know about this one, but can confirm we don't use it. 2) org.apache.hcatalog.pig.drivers - these are the ones I asked about. Unless anyone knows a good reason not to, I think we should remove them. Re: the pig package, I think we should go a step further and make these three classes package private so they are not part of our exposed API: HCatBaseLoader.java, HCatBaseStorer.java, PigHCatUtil.java. This would simplify and clarify our public Pig support to just the loader & storer. I believe this is already what we intend, and this would clarify that via our API. Thanks for bringing this up Arup! I totally agree there's some room to reduce confusion in our code base. --travis On Mon, Oct 8, 2012 at 3:05 PM, Arup Malakar <[email protected]> wrote: > Hi, > > I see that there are few dead classes in hcatalog source tree following > code. I guess they are not used anymore and are there for historical > reasons. > If that is the case can we remove them? > > 1. org.apache.hcatalog.rcfile.RCFileMapReduceOutputFormat > 2. The classes in the following package: > > org.apache.hcatalog.pig.drivers ( > > https://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/drivers/ > ) > > And they are: > LoadFuncBasedInputDriver.java.broken > LoadFuncBasedInputFormat.java > PigStorageInputDriver.java.broken > StoreFuncBasedOutputDriver.java.broken > StoreFuncBasedOutputFormat.java > > > Thanks, > Arup >
