[
https://issues.apache.org/jira/browse/HCATALOG-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472026#comment-13472026
]
Travis Crawford commented on HCATALOG-525:
------------------------------------------
There's [another thread on
hcat-dev|http://mail-archives.apache.org/mod_mbox/incubator-hcatalog-dev/201210.mbox/%3CCABN7xTBzm7MuSGV%3DO%3D8piSJ5Ke1rTr6rT4tpS2cF_1MOrq8dEA%40mail.gmail.com%3E]
about the pig drivers package. AFAICT that package was quite useful when
storage drivers were around, but is no longer needed after switching to
serde's. Since switching to serde's was a backwards-incompatible change, I
don't believe these even work for anyone and could be removed without a
deprecation cycle.
Additionally, what do you think about making these three classes package
private? As far as I can tell there's no reason to expose them - they're
implementation details and I believe should never have been exposed to begin
with. Combined with removing the driver package we'll have a super clean Pig
API.
* HCatBaseLoader.java
* HCatBaseStorer.java
* PigHCatUtil.java
> Remove dead classes from HCatalog Source Tree
> ---------------------------------------------
>
> Key: HCATALOG-525
> URL: https://issues.apache.org/jira/browse/HCATALOG-525
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.4, 0.5
> Reporter: Arup Malakar
> Assignee: Arup Malakar
> Priority: Trivial
>
> I see that there are few dead classes in hcatalog source tree. I guess they
> are not used anymore and are there for historical reasons.
> If that is the case can we remove them?
> org.apache.hcatalog.rcfile.RCFileMapReduceOutputFormat
> The classes in the following package:
> org.apache.hcatalog.pig.drivers
> (https://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/pig/drivers/)
> And they are:
> LoadFuncBasedInputDriver.java.broken
> LoadFuncBasedInputFormat.java
> PigStorageInputDriver.java.broken
> StoreFuncBasedOutputDriver.java.broken
> StoreFuncBasedOutputFormat.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
