> On Nov. 7, 2012, 7:31 p.m., Travis Crawford wrote: > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/listener/NotificationListener.java, > > line 84 > > <https://reviews.apache.org/r/7909/diff/2/?file=186168#file186168line84> > > > > I think this indentation is off. Doesn't checkstyle complain about this?
Fixing the indentation through the file caused a bunch of white-spaces to turn up as changes. I'd have preferred to avoid that, but it's best things were fixed. > On Nov. 7, 2012, 7:31 p.m., Travis Crawford wrote: > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONMessageFactory.java, > > line 6 > > <https://reviews.apache.org/r/7909/diff/2/?file=186186#file186186line6> > > > > Can you import everything individually, instead of using star? Also, > > let's add a checkstyle rule to prevent star imports in the future. Sorry. New IDE install. - Mithun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7909/#review13218 ----------------------------------------------------------- On Nov. 7, 2012, 1:28 a.m., Mithun Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7909/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2012, 1:28 a.m.) > > > Review request for hcatalog, Alan Gates and Francis Liu. > > > Description > ------- > > In 0.4.1, the NotificationListener listens for metastore operations and emits > JMS notifications containing the entire metastore-objects > (Database/Table/Partitions) in Java-serialized form. The assumption at the > time was that consumers might need access to the whole object. This policy > poses a couple of problems: > 1. The notifications are verbose, since it conveys a bunch of information > that's available from querying the metastore anyway. > 2. Consumers of these JMS notifications (e.g. Oozie) would now be dependent > on the Java class definitions of metastore-objects. If they change, Oozie > would also need to be restarted (with updated libs), to consume the > notifications. > Ideally, the notifications should convey only the minimum information that > identifies the metastore-change unambiguously. (Everything else can be > queried for.) They should be backward compatible. If new fields are added, > existing consumers shouldn't break (unless they intend to consume the new > fields). Also, the notification-format ought to be pluggable. > For the initial rework, we're proposing to use a JSON-string to represent the > notification-content. We're also proposing a helper-class for the likes of > Oozie to use, that converts the strings to POJOs, in a backward-compatible > fashion. > > > This addresses bug HCATALOG-546. > https://issues.apache.org/jira/browse/HCATALOG-546 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/common/HCatConstants.java > 1406411 > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/listener/NotificationListener.java > 1406411 > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/AddPartitionMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/CreateDatabaseMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/CreateTableMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/DropDatabaseMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/DropPartitionMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/DropTableMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/HCatEventMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/MessageDeserializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/MessageFactory.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/jms/MessageHelper.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONAddPartitionMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONCreateDatabaseMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONCreateTableMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONDropDatabaseMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONDropPartitionMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONDropTableMessage.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONMessageDeserializer.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONMessageFactory.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/java/org/apache/hcatalog/messaging/json/JSONMessageUtils.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/listener/TestNotificationListener.java > 1406411 > > http://svn.apache.org/repos/asf/incubator/hcatalog/branches/branch-0.4/src/test/org/apache/hcatalog/messaging/json/TestJSONMessageDeserializer.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/7909/diff/ > > > Testing > ------- > > > Thanks, > > Mithun Radhakrishnan > >
