[
https://issues.apache.org/jira/browse/HCATALOG-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495860#comment-13495860
]
Travis Crawford commented on HCATALOG-549:
------------------------------------------
Hey [~thejas] - can you post patches in reviewboard? Its a lot easier to review
that way. A few comments:
For some reason I thought Apache releases shouldn't package 3rdparty jars.
Should we be doing the following?
{code}
+ <copy todir="${dist.dir}/share/webhcat/svr/lib/"
includeEmptyDirs="false">
+ <fileset dir="webhcat/svr/build/lib/compile/">
+ <include name="*.jar"/>
+ </fileset>
+ </copy>
{code}
Let's continue using the name {{java-client}} in the directory, since it lets
us add different language clients in the future without changes. That was the
rationale when going with the {{java-client}} subproject directory name and we
should propagate that through to packaging too.
{code}
+ <copy todir="${dist.dir}/share/webhcat/client/"
includeEmptyDirs="false">
+ <fileset dir="webhcat/java-client/build">
+ <include name="webhcat-java-client*.jar"/>
+ </fileset>
+ </copy>
{code}
At packaging time we shouldn't need to change directory structures like
follows. We should put these webhcat server config files in
{{webhcat/svr/src/main/config}} as is the maven directory layout. When creating
the final dist dir we can simply copy the directory as-is over to
{{${dist.dir}/etc/webhcat}}
{code}
<copy todir="${dist.dir}/etc/${ant.project.name}">
- <fileset dir="conf"/>
+ <fileset dir="conf">
+ <exclude name="webhcat*"/>
+ </fileset>
+ </copy>
+
+ <copy todir="${dist.dir}/etc/webhcat">
+ <fileset dir="conf">
+ <include name="webhcat*"/>
+ </fileset>
</copy>
{code}
In the renamed {{webhcat-default.xml}} we still see templeton references. For
example:
{code}
<property>
+ <name>templeton.port</name>
+ <value>50111</value>
+ <description>The HTTP port for the main server.</description>
+ </property>
{code}
> rename webhcat config and shell scripts to use webhcat in the names
> -------------------------------------------------------------------
>
> Key: HCATALOG-549
> URL: https://issues.apache.org/jira/browse/HCATALOG-549
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Thejas M Nair
> Assignee: Thejas M Nair
> Fix For: 0.5
>
> Attachments: HCATALOG-549.1.patch
>
>
> The shell scripts and config files used for webhcat server should be called
> webhcat* instead of templeton* .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
