> On Nov. 14, 2012, 9:40 p.m., Vandana Ayyalasomayajula wrote:
> > Ship It!
> 
> Francis Liu wrote:
>     Thanks for reviewing Vandana!

Awesome, thanks for the review!

So we don't lose history, I'm using "svn mv" instead of directly applying this 
patch. I've regenerated the patch excluding the moved files, and will post that 
final version, as well as the shell commands + output when applying.

Since this change is quite invasive I've made sure to set aside time to fix 
anything we didn't catch during testing/review, or to make changes if someone 
notices anything strange. Please let me know if you're having issues after this 
change and I'll take a look ASAP.


- Travis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7969/#review13441
-----------------------------------------------------------


On Nov. 13, 2012, 7:42 p.m., Travis Crawford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7969/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2012, 7:42 p.m.)
> 
> 
> Review request for hcatalog.
> 
> 
> Description
> -------
> 
> The primary goal of this patch is refactoring HCatalog source/build so "core" 
> is a proper submodule. The vast majority of this change is moving source/test 
> files into the core subproject directory with no changes. In this diff they 
> show up as delete/add which is why the patch is so giant. You may find an 
> easier to read version by looking at this branch, which shows the actual file 
> changes separate from file renames:
> 
> https://github.com/traviscrawford/hcatalog/compare/HCATALOG-518_core_submodule
> 
> A few useful side-effects of this change are:
> 
> * We have entirely removed Ivy from our build! Everything is resolved with 
> maven now.
> * POM files are correctly formed, and published artifacts are now usable from 
> a maven repo (previously there was a version variable issue).
> * Dependencies in the core jar have been simplified. For example, only 
> webhcat depends on jersey, only the HBase storage driver depends on HBase, 
> etc.
> 
> Thanks for Francis for pairing to get this done so quickly!
> 
> 
> This addresses bug HCATALOG-518.
>     https://issues.apache.org/jira/browse/HCATALOG-518
> 
> 
> Diffs
> -----
> 
>   .gitignore e421e48 
>   ant/checkstyle.xml 1d75e5d 
>   ant/dependencies.xml 376cf28 
>   ant/deploy.xml 270a745 
>   build-common.xml cab3f66 
>   build.properties 600ee51 
>   build.xml 86b1fd9 
>   core/build.xml PRE-CREATION 
>   core/pom.xml PRE-CREATION 
>   core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/cli/HCatCli.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/cli/HCatDriver.java PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/common/ErrorType.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/common/HCatConstants.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/common/HCatContext.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/common/HCatException.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/common/HCatUtil.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/DataType.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/DefaultHCatRecord.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/HCatRecord.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/HCatRecordSerDe.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/HCatRecordable.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/JsonSerDe.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/LazyHCatRecord.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/Pair.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/ReaderWriter.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/schema/HCatSchema.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/EntityBase.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/HCatReader.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/HCatWriter.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/ReadEntity.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/ReaderContext.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/WriteEntity.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/data/transfer/WriterContext.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/data/transfer/impl/HCatInputFormatReader.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/data/transfer/impl/HCatOutputFormatWriter.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/data/transfer/state/DefaultStateProvider.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/data/transfer/state/StateProvider.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/har/HarOutputCommitterPostProcessor.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputFormatContainer.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/DefaultRecordWriterContainer.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java.broken
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java.broken
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java.broken
>  PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatSplit.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/InitializeInput.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/InternalUtil.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/mapreduce/OutputCommitterContainer.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/PartInfo.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/ProgressReporter.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/RecordWriterContainer.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/Security.java PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/mapreduce/StorerInfo.java 
> PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/oozie/JavaAction.java PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/rcfile/RCFileMapReduceInputFormat.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/rcfile/RCFileMapReduceOutputFormat.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/rcfile/RCFileMapReduceRecordReader.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
>  PRE-CREATION 
>   core/src/main/java/org/apache/hcatalog/shims/HCatHadoopShims.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/hcatalog/storagehandler/DummyHCatAuthProvider.java
>  PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/ExitException.java PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/HcatTestUtils.java PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/MiniCluster.java PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/NoExitSecurityManager.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/cli/DummyStorageHandler.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java.broken
>  PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/cli/TestPermsGrp.java PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/cli/TestSemanticAnalysis.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/cli/TestStorageHandlerProperties.java.broken
>  PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/cli/TestUseDatabase.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/common/TestHCatUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/common/TestHiveClientCache.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/HCatDataCheckUtil.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/TestDefaultHCatRecord.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/TestHCatRecordSerDe.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/TestJsonSerDe.java PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/TestLazyHCatRecord.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/TestReaderWriter.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/schema/TestHCatSchema.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapred/TestHiveHCatInputFormat.java.broken
>  PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/HCatBaseTest.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java.broken
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java.broken
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatHiveThriftCompatibility.java
>  PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatInputFormat.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatNonPartitioned.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatPartitionPublish.java
>  PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatPartitioned.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/TestMultiOutputFormat.java 
> PRE-CREATION 
>   core/src/test/java/org/apache/hcatalog/mapreduce/TestPassProperties.java 
> PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/mapreduce/TestSequenceFileReadWrite.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/rcfile/TestRCFileInputStorageDriver.java.broken
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/rcfile/TestRCFileOutputStorageDriver.java.broken
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java
>  PRE-CREATION 
>   hcatalog-pig-adapter/build.xml 355201b 
>   hcatalog-pig-adapter/pom.xml 2b749a8 
>   ivy.xml c19972d 
>   ivy/ivysettings.xml cfe292a 
>   ivy/libraries.properties 4c9c3b1 
>   pom.xml 52783ea 
>   server-extensions/build.xml f753ce2 
>   server-extensions/pom.xml 3f6ee20 
>   shims/build.xml 683495d 
>   shims/ivy.xml 29eb330 
>   src/java/org/apache/hadoop/mapred/HCatMapRedUtil.java bc7280e 
>   src/java/org/apache/hcatalog/cli/HCatCli.java f305fe2 
>   src/java/org/apache/hcatalog/cli/HCatDriver.java 79b7a83 
>   src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateDatabaseHook.java 
> 9fa6e85 
>   src/java/org/apache/hcatalog/cli/SemanticAnalysis/CreateTableHook.java 
> 002f057 
>   src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java 
> b5151d0 
>   
> src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
>  df99a8e 
>   src/java/org/apache/hcatalog/common/ErrorType.java 9aeb91e 
>   src/java/org/apache/hcatalog/common/HCatConstants.java 1a9e6fc 
>   src/java/org/apache/hcatalog/common/HCatContext.java 1c40b5e 
>   src/java/org/apache/hcatalog/common/HCatException.java ed51c60 
>   src/java/org/apache/hcatalog/common/HCatUtil.java 0aa1014 
>   src/java/org/apache/hcatalog/common/HiveClientCache.java a9e5af8 
>   src/java/org/apache/hcatalog/data/DataType.java 687a67b 
>   src/java/org/apache/hcatalog/data/DefaultHCatRecord.java d8b30ee 
>   src/java/org/apache/hcatalog/data/HCatRecord.java 131d8d0 
>   src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java becadda 
>   src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java 
> de9f79d 
>   src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 468a1f5 
>   src/java/org/apache/hcatalog/data/HCatRecordable.java 3656bb7 
>   src/java/org/apache/hcatalog/data/JsonSerDe.java cac8e1a 
>   src/java/org/apache/hcatalog/data/LazyHCatRecord.java 6bcb138 
>   src/java/org/apache/hcatalog/data/Pair.java 9eb525f 
>   src/java/org/apache/hcatalog/data/ReaderWriter.java 79b4035 
>   src/java/org/apache/hcatalog/data/schema/HCatFieldSchema.java 720d7b0 
>   src/java/org/apache/hcatalog/data/schema/HCatSchema.java a18cb75 
>   src/java/org/apache/hcatalog/data/schema/HCatSchemaUtils.java b4060e9 
>   src/java/org/apache/hcatalog/data/transfer/DataTransferFactory.java f10ec8c 
>   src/java/org/apache/hcatalog/data/transfer/EntityBase.java 668057f 
>   src/java/org/apache/hcatalog/data/transfer/HCatReader.java 84465f9 
>   src/java/org/apache/hcatalog/data/transfer/HCatWriter.java 07c33c3 
>   src/java/org/apache/hcatalog/data/transfer/ReadEntity.java 6787b10 
>   src/java/org/apache/hcatalog/data/transfer/ReaderContext.java 68d653a 
>   src/java/org/apache/hcatalog/data/transfer/WriteEntity.java 3917a18 
>   src/java/org/apache/hcatalog/data/transfer/WriterContext.java 002ca07 
>   src/java/org/apache/hcatalog/data/transfer/impl/HCatInputFormatReader.java 
> cf9bba2 
>   src/java/org/apache/hcatalog/data/transfer/impl/HCatOutputFormatWriter.java 
> 03e59e8 
>   src/java/org/apache/hcatalog/data/transfer/state/DefaultStateProvider.java 
> e7455a3 
>   src/java/org/apache/hcatalog/data/transfer/state/StateProvider.java ddf7364 
>   src/java/org/apache/hcatalog/har/HarOutputCommitterPostProcessor.java 
> 7e4dba4 
>   src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java 
> 3b1df91 
>   src/java/org/apache/hcatalog/mapreduce/DefaultOutputFormatContainer.java 
> a87e7bb 
>   src/java/org/apache/hcatalog/mapreduce/DefaultRecordWriterContainer.java 
> 49cf05e 
>   src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java 
> d395f38 
>   src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java 
> 22d73da 
>   src/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java 
> 608c9fb 
>   src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java d4c3470 
>   src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java 8ca35dc 
>   src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java 7e2f0ec 
>   src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java.broken 
> 90c5671 
>   src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java.broken 
> 1ba8ccd 
>   src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java.broken 
> ed1ba66 
>   src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java 7a7446f 
>   src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 22293ab 
>   src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java e91d12c 
>   src/java/org/apache/hcatalog/mapreduce/HCatSplit.java c92d665 
>   src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java 1ebcaa4 
>   src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 8e69b7e 
>   src/java/org/apache/hcatalog/mapreduce/InitializeInput.java e91ddc7 
>   src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 8779c5e 
>   src/java/org/apache/hcatalog/mapreduce/InternalUtil.java 42c98c1 
>   src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java 62f3d14 
>   src/java/org/apache/hcatalog/mapreduce/OutputCommitterContainer.java 
> 9d6408e 
>   src/java/org/apache/hcatalog/mapreduce/OutputFormatContainer.java 50aeb35 
>   src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java f00cea5 
>   src/java/org/apache/hcatalog/mapreduce/PartInfo.java 63bcb43 
>   src/java/org/apache/hcatalog/mapreduce/ProgressReporter.java 936204b 
>   src/java/org/apache/hcatalog/mapreduce/RecordWriterContainer.java 1b40838 
>   src/java/org/apache/hcatalog/mapreduce/Security.java f505c4d 
>   src/java/org/apache/hcatalog/mapreduce/StorerInfo.java 57ec4c3 
>   src/java/org/apache/hcatalog/oozie/JavaAction.java f45f0e3 
>   src/java/org/apache/hcatalog/rcfile/RCFileMapReduceInputFormat.java 5301530 
>   src/java/org/apache/hcatalog/rcfile/RCFileMapReduceOutputFormat.java 
> 665b2dc 
>   src/java/org/apache/hcatalog/rcfile/RCFileMapReduceRecordReader.java 
> 126866a 
>   src/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java 
> cbafa0a 
>   
> src/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
>  546296c 
>   src/java/org/apache/hcatalog/shims/HCatHadoopShims.java ff59636 
>   src/java/org/apache/hcatalog/storagehandler/DummyHCatAuthProvider.java 
> 6c31c10 
>   src/test/org/apache/hcatalog/ExitException.java 5e429c5 
>   src/test/org/apache/hcatalog/HcatTestUtils.java 3348339 
>   src/test/org/apache/hcatalog/MiniCluster.java d7b54e6 
>   src/test/org/apache/hcatalog/NoExitSecurityManager.java b475602 
>   src/test/org/apache/hcatalog/cli/DummyStorageHandler.java ecc105e 
>   src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java.broken 
> eedda9e 
>   src/test/org/apache/hcatalog/cli/TestPermsGrp.java 96c0013 
>   src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java 20a36c5 
>   src/test/org/apache/hcatalog/cli/TestStorageHandlerProperties.java.broken 
> df8f5a5 
>   src/test/org/apache/hcatalog/cli/TestUseDatabase.java e97a9c2 
>   src/test/org/apache/hcatalog/common/TestHCatUtil.java 0adba5a 
>   src/test/org/apache/hcatalog/common/TestHiveClientCache.java 286f32c 
>   src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java dc09fdb 
>   src/test/org/apache/hcatalog/data/TestDefaultHCatRecord.java f86eee0 
>   src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java 5f102e9 
>   src/test/org/apache/hcatalog/data/TestJsonSerDe.java 5e363df 
>   src/test/org/apache/hcatalog/data/TestLazyHCatRecord.java b532df9 
>   src/test/org/apache/hcatalog/data/TestReaderWriter.java 18d368f 
>   src/test/org/apache/hcatalog/data/schema/TestHCatSchema.java 9402b4d 
>   src/test/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java 1d07621 
>   src/test/org/apache/hcatalog/mapred/TestHiveHCatInputFormat.java.broken 
> 28bac09 
>   src/test/org/apache/hcatalog/mapreduce/HCatBaseTest.java ae67513 
>   src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 74c4888 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java 
> d4fbc8d 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java.broken 
> 9d94c7b 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java.broken 
> 99ec02b 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatHiveCompatibility.java 
> aa450fc 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatHiveThriftCompatibility.java 
> 62dcb7c 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatInputFormat.java a6b381e 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 
> 597ab94 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatNonPartitioned.java c8c9790 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java 7333fa0 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatPartitionPublish.java 
> c4c3dd6 
>   src/test/org/apache/hcatalog/mapreduce/TestHCatPartitioned.java 00a58d5 
>   src/test/org/apache/hcatalog/mapreduce/TestMultiOutputFormat.java 35ee01c 
>   src/test/org/apache/hcatalog/mapreduce/TestPassProperties.java c890574 
>   src/test/org/apache/hcatalog/mapreduce/TestSequenceFileReadWrite.java 
> d89e885 
>   
> src/test/org/apache/hcatalog/rcfile/TestRCFileInputStorageDriver.java.broken 
> ecf3117 
>   src/test/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java 
> 80deeb7 
>   
> src/test/org/apache/hcatalog/rcfile/TestRCFileOutputStorageDriver.java.broken 
> 6ddd208 
>   src/test/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java 
> 68920fd 
>   storage-handlers/build.xml 484989a 
>   storage-handlers/hbase/build.xml cee25ec 
>   storage-handlers/hbase/pom.xml 73d97c9 
>   webhcat/java-client/build.xml 0b06dbc 
>   webhcat/java-client/pom.xml 82bba9a 
>   webhcat/svr/build.xml 7057dbd 
>   webhcat/svr/pom.xml 1bf6ef2 
> 
> Diff: https://reviews.apache.org/r/7969/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass and contents of dist dir look good
> 
> https://travis.ci.cloudbees.com/job/HCATALOG-518_core_submodule/
> 
> 
> Thanks,
> 
> Travis Crawford
> 
>

Reply via email to