[
https://issues.apache.org/jira/browse/HCATALOG-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501613#comment-13501613
]
Daniel Dai commented on HCATALOG-531:
-------------------------------------
+1, a good refactory for singleton.
> HCatContext should be an enum
> -----------------------------
>
> Key: HCATALOG-531
> URL: https://issues.apache.org/jira/browse/HCATALOG-531
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Fix For: 0.5
>
> Attachments: HCATALOG-531_hcatcontext_enum.1.patch
>
>
> [HCatContext|https://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/common/HCatContext.java]
> is a container for a configuration that is globally accessible both on the
> FE & BE. Its purpose is to simplify enabling optional functionality.
> When I originally added this class I didn't use an enum, not knowing its the
> recommended way of doing singletons in java. Since we haven't make a release
> with this class I think we should change it now to the "Right Way" before it
> gets much use.
> I also added annotations showing the intended audience, and added some pretty
> good javadocs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
