[
https://issues.apache.org/jira/browse/HCATALOG-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Crawford updated HCATALOG-527:
-------------------------------------
Attachment: HCATALOG-527_inputjobinfo_visibility.1.patch
Reviewboard: https://reviews.apache.org/r/8148/
Please consider this patch a request for feedback on the interface change. I'm
not entirely convinced it makes things easier for the user as-is. In the RB I
posted a few questions about the change and areas I would appreciate feedback.
> InputJobInfo should not be public
> ---------------------------------
>
> Key: HCATALOG-527
> URL: https://issues.apache.org/jira/browse/HCATALOG-527
> Project: HCatalog
> Issue Type: Bug
> Reporter: Travis Crawford
> Assignee: Travis Crawford
> Fix For: 0.5
>
> Attachments: HCATALOG-527_inputjobinfo_visibility.1.patch
>
>
> Writing a MapReduce job using HCatalog involves the following step (from
> [Input and Output
> Interfaces|http://incubator.apache.org/hcatalog/docs/r0.4.0/inputoutput.html):
> {code}
> HCatInputFormat.setInput(job, InputJobInfo.create(dbName,
> inputTableName, null));
> {code}
> Notice how we expose
> [InputJobInfo|https://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java]
> as part of the public API. The purpose of this class is to store the
> HiveMetaStore response data, and by serializing to the jobconf, passes that
> info to backend workers.
> Really this class is an implementation detail that should be hidden from
> users. In HCATALOG-453 where the size of InputJobInfo was addressed we had to
> be aware of potentially user-affecting changes to this class. In HCATALOG-341
> we clarified the usage of InputJobInfo because there was some confusion.
> Ideally we could go through a deprecation cycle and change our interface to
> hide this implementation detail from users, which clarifies things for users,
> and give us more implementation flexibility.
> {code}
> HCatInputFormat.setInput(job, dbName, inputTableName, null);
> {code}
> Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
