-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8260/
-----------------------------------------------------------
(Updated Nov. 30, 2012, 8:32 p.m.)
Review request for hcatalog.
Changes
-------
Hey Daniel, thanks for taking a look at this change! After seeing how our CI
job is run I made a few changes. Can you take another look?
* Update test.sh to have all options necessary to run from CI on
builds.apache.org.
* Update ant package target to create tarball, and remove separate tar target.
Also create tarball checksum file. Use external tar command rather than tar ant
task as the external command preserves fil
* Remove ant _test-with-clover target description. The target is internal and
the description causes it to show on the public ant target list.
This updates will let us update our CI job to run this script. This ensures
everyone's on the same page WRT what commands to run when testing.
Description
-------
This change is actually quite small; please see the note about moving the ant
files (no actual changes, just moved).
Handful of build updates/fixes:
- Fix src-release target to produce an artifact one can build from
- Move ant files under build-support to declutter the top-level directory; also
consolidates build-related files.
- Generate the src-release artifact checksum during the build, instead of
requiring the release manager from producing manually
- Update test.sh to produce a source release, then run tests from an extracted
source release. This ensures our release artifact works correctly.
This addresses bug HCATALOG-558.
https://issues.apache.org/jira/browse/HCATALOG-558
Diffs (updated)
-----
ant/checkstyle.xml 1f15b44
ant/deploy.xml 160e46f
ant/findbugs.xml f2b8f3c
ant/test.xml e3aaf1a
build-common.xml 7376256
build-support/ant/build-common.xml PRE-CREATION
build-support/ant/checkstyle.xml PRE-CREATION
build-support/ant/deploy.xml PRE-CREATION
build-support/ant/findbugs.xml PRE-CREATION
build-support/ant/test.xml PRE-CREATION
build-support/scripts/test.sh 0fd500b
build.xml 624f2cc
core/build.xml 6cd7441
hcatalog-pig-adapter/build.xml bdd9605
server-extensions/build.xml 8351f27
shims/build.xml 89a8f5c
storage-handlers/hbase/build.xml 558e9c8
webhcat/java-client/build.xml 7c12468
webhcat/svr/build.xml 070d9be
Diff: https://reviews.apache.org/r/8260/diff/
Testing
-------
Ran ./build-support/scripts/test.sh – making this work from an extracted source
release is the primary goal of this change.
Thanks,
Travis Crawford
