[ 
https://issues.apache.org/jira/browse/HCATALOG-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536108#comment-13536108
 ] 

Ashutosh Chauhan commented on HCATALOG-446:
-------------------------------------------

Travis,
I chatted with [~alangates] on this. He said rat in addition to checking for 
apache headers, also does some checking for other licenses and either raises 
flags (e.g if it finds GPL) or auto approves when it finds compliant licenses 
(like BSD or MIT). So, running checkstyle may not be sufficient for doing a 
release. On the other hand running checkstyle will do no harm, so refactoring 
of this patch is still useful. Since, it seems running rat is an apache 
requirement for doing a release, I will suggest to leave rat target as it is 
and don't delete it. Going forward, we should use checkstyle on regular basis 
and use rat at time of doing releases. 
                
> Enforce apache headers for all HCatalog code
> --------------------------------------------
>
>                 Key: HCATALOG-446
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-446
>             Project: HCatalog
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.5
>            Reporter: Alan Gates
>            Assignee: Travis Crawford
>            Priority: Blocker
>             Fix For: 0.5
>
>         Attachments: HCATALOG-446_rm_releaseaudit.1.patch, 
> HCATALOG-446_rm_releaseaudit.2.patch
>
>
> The current releaseaudit target only looks for code under src.  This means it 
> is missing code in hcatalog-pig-adaptor and storage-handler directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to