[ 
https://issues.apache.org/jira/browse/HCATALOG-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556377#comment-13556377
 ] 

Travis Crawford commented on HCATALOG-587:
------------------------------------------

Taking a closer look at {{AppConfig}}, I'm a little confused about the intended 
usage. Here's an existing config file key, and how you could get it:

{code}
    // in AppConfig
    public static final String HADOOP_NAME         = "templeton.hadoop";
    public String clusterHadoop()    { return get(HADOOP_NAME); }

    // inherited from Configuration
    public String get(String name);
{code}

The confusion comes from having two ways to get at this config value. Since 
both {{HADOOP_NAME}} and {{get()}} are public you can get values from the 
config that way (common in the hadoop-ecosystem projects), as well as having a 
public {{clusterHadoop()}} convenience method.

Since this is a bugfix, how about we use the local style of accessing values 
through a custom getter (as implemented in v2 of this patch)? We can file an 
improvement issue to clarify this class in a future release.

[~thejas] - does this work for you?
                
> webhcat controller map task takes too much memory
> -------------------------------------------------
>
>                 Key: HCATALOG-587
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-587
>             Project: HCatalog
>          Issue Type: Bug
>          Components: webhcat-svr
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>             Fix For: 0.5, 0.6
>
>         Attachments: HCATALOG-587.1.patch, HCATALOG-587.2.patch, 
> HCATALOG-587.3.patch
>
>
> The webhcat map only task does not need lot of memory. But when a java 
> application is started with -server option, it allocates the memory specified 
> as max heap size (-Xmx in oracle jre) upfront.
> When combined with the memory used by pig or hive client, this can sometimes 
> exceed the maximum memory limit for a map task (if configured).
> Being able to specify the java options for the map task will be useful to 
> avoid this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to