[ 
https://issues.apache.org/jira/browse/HCATALOG-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556802#comment-13556802
 ] 

Mithun Radhakrishnan commented on HCATALOG-599:
-----------------------------------------------

Here's the review: https://reviews.apache.org/r/9013/
                
> NotificationListener doesn't use getTopic() for sending messages.
> -----------------------------------------------------------------
>
>                 Key: HCATALOG-599
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-599
>             Project: HCatalog
>          Issue Type: Bug
>          Components: notification
>    Affects Versions: 0.5
>            Reporter: Mithun Radhakrishnan
>            Assignee: Mithun Radhakrishnan
>         Attachments: HCATALOG-599.branch5.patch, HCATALOG-599.trunk.patch
>
>
> This is related to HCATALOG-546 and HCATALOG-548.
> HCATALOG-548 allowed one to customize topic-creation for ActiveMQ 
> notifications.
> HCATALOG-546 redid JMS Notifications. But in the process, it overwrote 
> changes in HCATALOG-548. (Specifically, it doesn't call getTopic() to create 
> topics.)
> This needs undoing. send() should call getTopic() instead of hard-coding how 
> the topic is created.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to