----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9641/#review17193 -----------------------------------------------------------
Thanks for the contribution! We definitely need to fix up the installation instructions. These can actually be further simplified – users no longer need to specify the version number nor is forrest used when creating a binary tarball. #simplify http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/docs/src/documentation/content/xdocs/install.xml <https://reviews.apache.org/r/9641/#comment36471> Forrest is no longer required when building a release package. Can you remove this section too? http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/docs/src/documentation/content/xdocs/install.xml <https://reviews.apache.org/r/9641/#comment36472> HCatalog source releases extract themselves into a subdirectory of cwd (not cwd itself), so this section feels a bit awkward. How about: """ Produce an HCatalog binary tarball as follows: tar -xzf hcatalog-src-0.5.0-incubating.tar.gz cd hcatalog-src-0.5.0-incubating ant_home/bin/ant package The binary tarball is created at build/hcatalog-0.5.0-incubating.tar.gz """ - Travis Crawford On Feb. 27, 2013, 2:14 a.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9641/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 2:14 a.m.) > > > Review request for hcatalog and Ashutosh Chauhan. > > > Description > ------- > > Cut-pasted from JIRA: > Source : > http://incubator.apache.org/hcatalog/docs/r0.5.0/install.html#Server+Installation+from+Source > Need to update these: > 1. ant command specify the target "tar" which is no longer a valid target. > Can be replaced with "package" instead. > 2. parameter "-Dhcatalog.version=0.5.0" needs to be replaced by > "-Dhcatalog.version=0.5.0-incubating". > 3. In one place, it refers to hive 0.10 and in another place, it refers to > 0.9 as an example. Making them consistent through out the doc will be less > confusing. For example, make it 0.20.0. > > > This addresses bug HCATALOG-625. > https://issues.apache.org/jira/browse/HCATALOG-625 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/docs/src/documentation/content/xdocs/install.xml > 1450533 > > Diff: https://reviews.apache.org/r/9641/diff/ > > > Testing > ------- > > Manual. > Build and visualize through browser. > > > Thanks, > > Mohammad Islam > >
