----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9886/#review17911 -----------------------------------------------------------
Looks good. Mostly minor comments. Almost ready to be shipped. server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37913> Couldn't we just: return createSession(); ? server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37914> Minor: Whitespace. server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37980> Minor: Shouldn't we do a testAndCreateConnection() here? The first call to send will otherwise be guaranteed to throw and exception. We're guaranteed to use up a retry. server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37916> Very cute. I'd have iterated. server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37981> Good cleanup, this. server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37982> Catch JMSException instead of Exception? server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37983> Why do we not close the session here? server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java <https://reviews.apache.org/r/9886/#comment37984> Should we catch an Exception here, not JMSException? - Mithun Radhakrishnan On March 12, 2013, 8:44 p.m., Arup Malakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9886/ > ----------------------------------------------------------- > > (Updated March 12, 2013, 8:44 p.m.) > > > Review request for hcatalog and Mithun Radhakrishnan. > > > Description > ------- > > Changes: > 1. Added threadlocal for session variables > 2. Added health check for connection > 3. Exposed retry in a cleaner way and retry is done from only one place > 4. Moved creation of topic/session etc so, that users can override them for > their JMS vendor if they wish to > 5. Connection close is sufficient and session close could be omitted > > > This addresses bug HCATALOG-627. > https://issues.apache.org/jira/browse/HCATALOG-627 > > > Diffs > ----- > > > server-extensions/src/main/java/org/apache/hcatalog/listener/NotificationListener.java > 7551a27a78bf9db728f1bc719ca77aacdb26dc5c > > Diff: https://reviews.apache.org/r/9886/diff/ > > > Testing > ------- > > > Thanks, > > Arup Malakar > >
