[ 
https://issues.apache.org/jira/browse/HCATALOG-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606800#comment-13606800
 ] 

Sushanth Sowmyan commented on HCATALOG-624:
-------------------------------------------

Read through to understand, and tested building and testing with hadoop23 and 
hadoop20, I checked the 624-2 patch against branch 0.5. I've not looked at your 
trunk patch yet, but I expect it to be okay, will do a quick verify before I +1.

Basically, looks good, and tests succeed. A couple of comments:

a) After I got into testing, I didn't read the jira comments till after I'd run 
them all and had the hbase tests fail. This is entirely my fault for not 
reading your instructions, but something I think people will hit when they 
download hcat and try running tests. Do you know if mvn artifacts for hadoop2 
going to be published by hbase? 
b) I see you changed some of the tests with pig schemas with parenthesis to not 
have the parenthesis any more, along with changing the pig dependency version. 
Should that be a separate patch by itself? I think it might make sense to 
separate 23-migration bugs with pig-upgrade and schema change bugs. Thoughts?

                
> Fix HCat for hadoop 2
> ---------------------
>
>                 Key: HCATALOG-624
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-624
>             Project: HCatalog
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.5
>
>         Attachments: HCATALOG-624-1.patch, HCATALOG-624-2.patch, 
> HCATALOG-624-3.patch
>
>
> We fixed hcatalog for hadoop 2 in HCATALOG-375. However, it is broken with 
> recent changes. Plus, the new component webhcat never works with hadoop 2. We 
> need to fix it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to