[ 
https://issues.apache.org/jira/browse/HCATALOG-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613355#comment-13613355
 ] 

Lefty Leverenz commented on HCATALOG-642:
-----------------------------------------

Good fixes, thanks.

# For configure{color:green}Output{color}JobProperties, does 
{color:green}InputFormat{color} belong among the bundled artifacts or should it 
be changed to {color:green}OutputFormat{color}?
bq. This method is called to allow the StorageHandlers to populate the 
JobContext.getConfiguration() with properties needed by the handler's bundled 
artifacts (eg, InputFormat, SerDe, etc).
# How about using the last sentence first, or adding it to the first sentence 
so it'll appear in the summary?
* "This method -in particular- is to create a configuration for input / output. 
 It allows the StorageHandlers to populate ...."
* "This method creates a configuration for input / output by populating the 
JobContext.getConfiguration() with ...."
                
> Fix language issues in javadoc description for HCatStorageHandler
> -----------------------------------------------------------------
>
>                 Key: HCATALOG-642
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-642
>             Project: HCatalog
>          Issue Type: Documentation
>          Components: documentation
>    Affects Versions: 0.5
>            Reporter: Scott Preece
>            Priority: Minor
>         Attachments: HCATALOG-642.patch
>
>
> The description text for HCatStorageHandler had a number of grammatical 
> errors. The patch text cleans up the errors and improves wording in several 
> places.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to