Hi Steffen,
On Mar 6, 2015, at 4:31 AM, Steffen Kieß <[email protected]>
wrote:
> Hello,
>
> On 2014-04-10 21:14, Elena Pourmal wrote:
>> Hi Steffen,
>>
>> Thank you for the patch. I created an issue in our JIRA database
>> HDFFV-8740. Unfortunately, we had code freeze for 1.8.13 already, and
>> will not be able to consider it for the upcoming release, but we will
>> try to do our best fro the next one.
>
> what's the status on this? The patch still applies cleanly to the current SVN
> trunk. Is there anything I can do to help?
>
>
Thank you for your question! It was very timely.
Your patch was reviewed before 1.8.14 release but didn’t make it into the
1.8.14 release due to a few missing items (see below).
Would it be possible for you to create:
1. A test for this new functionality that passes at least on Linux and
Windows.
Please take a look at the test/dset.c and test/external.c files and add
the new tests where they fit best. Separate test file is also OK, but then you
will need to modify
autoconf and CMake related files, and I don’t think it makes sense in
this particular case.
2. Add the tests to the h5dump, h5ls, h5diff and h5repack tools.
3. A short paragraph that describes the issue and the fix for it for the
RELEASE.txt file.
4. Enhancements to the HDF5 Reference Manual and User’s Guide entries for
H5Pset_external where applicable.
Code freeze for 1.8.15 is April 1, 2015. We will need the patches for 1. and 2.
before March 25 to tests it on the platforms beyond Linux and Windows.
Documentation patches should be provided by April 15.
Please let me know if you have any questions.
Thank you!
Elena
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Elena Pourmal The HDF Group http://hdfgroup.org
1800 So. Oak St., Suite 203, Champaign IL 61820
217.531.6112
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Best regards,
> Steffen Kieß
>
>
>>
>> On Apr 4, 2014, at 10:10 AM, Steffen Kieß
>> <[email protected]
>> <mailto:[email protected]>> wrote:
>>
>>> Hello,
>>>
>>> currently relative file names set with H5Pset_external() will be
>>> interpreted as relative to the current directory.
>>>
>>> The attached patch (against SVN trunk r24959) changes this to relative
>>> to the HDF5 file, which is probably what most users want when they use
>>> H5Pset_external().
>>>
>>>
>>> Best regards,
>>> Steffen Kieß
>>> <relative-external-files.patch>_______________________________________________
>>> Hdf-forum is for HDF software users discussion.
>>> [email protected] <mailto:[email protected]>
>>> http://mail.lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
>>
>>
>>
>> _______________________________________________
>> Hdf-forum is for HDF software users discussion.
>> [email protected]
>> http://mail.lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
>>
>
>
> _______________________________________________
> Hdf-forum is for HDF software users discussion.
> [email protected]
> http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
> Twitter: https://twitter.com/hdf5
_______________________________________________
Hdf-forum is for HDF software users discussion.
[email protected]
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5
