On 4/22/2015 2:01 PM, Elena Pourmal wrote:
Hi Marco,
2) I wasted some time to discover this change
## Disable shared libraries on CYGWIN. (LK - 04/16/15)
## A number of tests run by "make check" fail on CYGWIN, so for HDF5
v1.8.15
## we will change the default for shared libraries to disabled.
...
This seems, in my humble opinion, a questionable approach.
I am running tests with shared libraries re-enabled and
I will look on these new failures.
dt_arith test fails with the shared libraries. If you need to build
shared, you should be able to use the —enable-shared configure option.
Elena,
Please look at the code.
It was "—enable-shared" until 1.8.14 (with --enable-unsupported)
It was removed in the 1.8.15-pre3.
Attached patch I used to re-instate the 1.8.14 behavior.
About dt_arith:
I see only 1 failure
-------------------------------------------------------
Testing non-aligned conversions (ALIGNMENT=1)....
Testing query functions of compiler conversion
*FAILED*
Can't query conversion function
-------------------------------------------------------
and it is NOT a regression.
Regards
Marco
--- origsrc/hdf5-1.8.15-pre3/configure.ac 2015-04-20 22:16:36.000000000
+0200
+++ src/hdf5-1.8.15-pre3/configure.ac 2015-04-21 14:37:52.280584200 +0200
@@ -637,17 +637,21 @@
AC_SUBST([TESTPARALLEL])
## ----------------------------------------------------------------------
-## Disable shared libraries on CYGWIN. (LK - 04/16/15)
-## A number of tests run by "make check" fail on CYGWIN, so for HDF5 v1.8.15
-## we will change the default for shared libraries to disabled.
+## Shared libraries are not currently supported under Cygwin, so configure
+## disables them unless --enable-unsupported has been supplied by the user.
-
-case "`uname`" in
- CYGWIN*)
- enable_shared="no"
- CHECK_WARN="Shared libraries are not currently supported on CYGWIN."
- ;;
-esac
+if test "X${ALLOW_UNSUPPORTED}" != "Xyes"; then
+ case "`uname`" in
+ CYGWIN*)
+ if test "X${enable_shared}" = "Xyes"; then
+ echo ' warning: shared libraries are not supported on Cygwin!'
+ echo ' disabling shared libraries'
+ echo ' use --enable-unsupported to override this warning and keep
shared libraries enabled'
+ fi
+ enable_shared="no"
+ ;;
+ esac
+fi
## ----------------------------------------------------------------------
## Fortran libraries are not currently supported on Mac. Disable them.
_______________________________________________
Hdf-forum is for HDF software users discussion.
Hdf-forum@lists.hdfgroup.org
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5
