Line 185 of h5pfc on version 1.8.17 has a typo. outputfile should be output_file

sed -e 's/outputfile/output_file/g' h5pfc


184       if test "x$do_link" = "xyes" -a -n "$output_file"; then
185         #Original code:  compile_args="$compile_args -o $outputfile"
186         compile_args="$compile_args -o $output_file"
187       fi


I noticed when trying to use h5pfc that a file argument was being dropped before getting passed to the compiler. If I passed the (-c) switch before (-o) the argument would be passed but not the other way. Turns out that there was this typo and that fixed it.

With Typo:

Case (-o) before (-c) resulted in dropped argument and compiler fails:
h5pfc -show -o ESMF_Base.o -c ESMF_Base.f
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c -o ESMF_Base.f


Case (-c) before (-o) worked but WRF for example doesn't use this order:
h5pfc -show -c ESMF_Base.f -o ESMF_Base.o
mpif90 -I/pkgs/hdf5/v1.8.17_mpi-pgi16.3_gcc_EL7/include -c ESMF_Base.f -o ESMF_Base.o


After fixing typo both parameters are passed to the compiler no matter what order is used.

David C




_______________________________________________
Hdf-forum is for HDF software users discussion.
[email protected]
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5

Reply via email to