On 08/04/2017 02:55, Marco Atzeri wrote:
Just built 1.8.18 on cygwin.The following shared libs are only for test purpose and not supposed to installed /usr/bin/cygdynlib1-0.dll /usr/bin/cygdynlib2-0.dll /usr/bin/cygdynlib3-0.dll /usr/bin/cygdynlib4-0.dll /usr/bin/cygdynlibadd-0.dll /usr/bin/cygdynlibvers-0.dll as there is a install-exec-hook: $(RM) $(DESTDIR)$(libdir)/*dynlib* that however seems ineffective on 1.8.18. Anyone saw the same on other platforms ? In addition the attached patch was needed to to properly link the shared libs to libhdf5 due to no-undefined requirements. Thanks Marco
attached updated version that remove the need of install-exec-hook using the proper noinst declaration. The install-exec-hook did not work properly on cygwin as the shared libs are not installed on "libdir" It also properly define the needed libdy...._la_LIBADD=$(LIBHDF5) to avoid no-undefined issues on platform expecting it. Regards Marco
--- origsrc/hdf5-1.8.18/test/Makefile.am 2016-11-04 19:41:07.000000000 +0100 +++ src/hdf5-1.8.18/test/Makefile.am 2017-04-08 14:21:28.181585500 +0200 @@ -77,18 +77,18 @@ endif if HAVE_SHARED_CONDITIONAL # The libh5test library provides common support code for the tests. - noinst_LTLIBRARIES=libh5test.la # The libdynlib1, libdynlib2, libdynlib3, and libdynlib4 library for testing plugin module plugin.c. # Build it as shared library if configure is enabled for shared library. - lib_LTLIBRARIES=libdynlib1.la libdynlib2.la libdynlib3.la libdynlib4.la + noinst_LTLIBRARIES=libh5test.la libdynlib1.la libdynlib2.la libdynlib3.la libdynlib4.la libdynlib1_la_SOURCES=dynlib1.c libdynlib2_la_SOURCES=dynlib2.c libdynlib3_la_SOURCES=dynlib3.c libdynlib4_la_SOURCES=dynlib4.c - -install-exec-hook: - $(RM) $(DESTDIR)$(libdir)/*dynlib* + libdynlib1_la_LIBADD=$(LIBHDF5) + libdynlib2_la_LIBADD=$(LIBHDF5) + libdynlib3_la_LIBADD=$(LIBHDF5) + libdynlib4_la_LIBADD=$(LIBHDF5) else # The libh5test library provides common support code for the tests. @@ -96,6 +96,7 @@ else endif libh5test_la_SOURCES=h5test.c testframe.c cache_common.c +libh5test_la_LIBADD=$(LIBHDF5) # Use libhd5test.la to compile all of the tests LDADD=libh5test.la $(LIBHDF5) --- origsrc/hdf5-1.8.18/tools/h5repack/Makefile.am 2016-11-04 19:41:07.000000000 +0100 +++ src/hdf5-1.8.18/tools/h5repack/Makefile.am 2017-04-08 14:21:28.219587700 +0200 @@ -63,12 +63,12 @@ h5repack.sh.chkexe_: h5repacktst.chkexe_ if HAVE_SHARED_CONDITIONAL # Build it as shared library if configure is enabled for shared library. - lib_LTLIBRARIES=libdynlibadd.la libdynlibvers.la + noinst_LTLIBRARIES=libdynlibadd.la libdynlibvers.la libdynlibadd_la_SOURCES=dynlib_rpk.c libdynlibvers_la_SOURCES=dynlib_vrpk.c + libdynlibadd_la_LIBADD=$(LIBHDF5) + libdynlibvers_la_LIBADD=$(LIBHDF5) -install-exec-hook: - $(RM) $(DESTDIR)$(libdir)/*dynlib* endif # Temporary files. *.h5 are generated by h5repack. They should
_______________________________________________ Hdf-forum is for HDF software users discussion. [email protected] http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org Twitter: https://twitter.com/hdf5
