Author: wheat9 Date: Thu Mar 6 18:51:04 2014 New Revision: 1574997 URL: http://svn.apache.org/r1574997 Log: HDFS-6062. TestRetryCacheWithHA#testConcat is flaky. Contributed by Jing Zhao.
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1574997&r1=1574996&r2=1574997&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original) +++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Thu Mar 6 18:51:04 2014 @@ -698,6 +698,8 @@ Release 2.4.0 - UNRELEASED HDFS-6058. Fix TestHDFSCLI failures after HADOOP-8691 change. (Akira Ajisaka via wheat9) + HDFS-6062. TestRetryCacheWithHA#testConcat is flaky. (Jing Zhao via wheat9) + BREAKDOWN OF HDFS-5698 SUBTASKS AND RELATED JIRAS HDFS-5717. Save FSImage header in protobuf. (Haohui Mai via jing9) Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java?rev=1574997&r1=1574996&r2=1574997&view=diff ============================================================================== --- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java (original) +++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java Thu Mar 6 18:51:04 2014 @@ -562,10 +562,12 @@ public class TestRetryCacheWithHA { @Override void prepare() throws Exception { - DFSTestUtil.createFile(dfs, new Path(target), BlockSize, DataNodes, 0); + final Path targetPath = new Path(target); + DFSTestUtil.createFile(dfs, targetPath, BlockSize, DataNodes, 0); for (int i = 0; i < srcPaths.length; i++) { DFSTestUtil.createFile(dfs, srcPaths[i], BlockSize, DataNodes, 0); } + assertEquals(BlockSize, dfs.getFileStatus(targetPath).getLen()); } @Override @@ -576,10 +578,12 @@ public class TestRetryCacheWithHA { @Override boolean checkNamenodeBeforeReturn() throws Exception { Path targetPath = new Path(target); - boolean done = dfs.exists(targetPath); + boolean done = dfs.getFileStatus(targetPath).getLen() == BlockSize + * (srcs.length + 1); for (int i = 0; i < CHECKTIMES && !done; i++) { Thread.sleep(1000); - done = dfs.exists(targetPath); + done = dfs.getFileStatus(targetPath).getLen() == BlockSize + * (srcs.length + 1); } return done; }