Author: cnauroth
Date: Thu May 29 22:56:58 2014
New Revision: 1598437
URL: http://svn.apache.org/r1598437
Log:
HDFS-6463. Clarify behavior of AclStorage#createFsPermissionForExtendedAcl in
comments. Contributed by Chris Nauroth.
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclStorage.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1598437&r1=1598436&r2=1598437&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Thu May 29
22:56:58 2014
@@ -454,6 +454,9 @@ Release 2.5.0 - UNRELEASED
HDFS-6447. balancer should timestamp the completion message.
(Juan Yu via wang).
+ HDFS-6463. Clarify behavior of AclStorage#createFsPermissionForExtendedAcl
+ in comments. (cnauroth)
+
OPTIMIZATIONS
HDFS-6214. Webhdfs has poor throughput for files >2GB (daryn)
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclStorage.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclStorage.java?rev=1598437&r1=1598436&r2=1598437&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclStorage.java
(original)
+++
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclStorage.java
Thu May 29 22:56:58 2014
@@ -338,6 +338,10 @@ final class AclStorage {
* ACL, based on its access ACL entries. For a correctly sorted ACL, the
* first entry is the owner and the last 2 entries are the mask and other
* entries respectively. Also preserve sticky bit and toggle ACL bit on.
+ * Note that this method intentionally copies the permissions of the mask
+ * entry into the FsPermission group permissions. This is consistent with
the
+ * POSIX ACLs model, which presents the mask as the permissions of the group
+ * class.
*
* @param accessEntries List<AclEntry> access ACL entries
* @param existingPerm FsPermission existing permissions
