----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/125/ -----------------------------------------------------------
Review request for hadoop-hdfs. Summary ------- The namenode need not be in safemode while runnign the saveNamespace command. The saveNamespace command acquires the FSNamesystem writelock, thus preventing anybody else from modifying the namespace. The lease expiry thread in the LeaseManager acquires the FSNamesystem-writelock too, so it is well protected. This addresses bug HDFS-1508. https://issues.apache.org/jira/browse/HDFS-1508 Diffs ----- http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java 1040699 http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java 1040699 Diff: https://reviews.apache.org/r/125/diff Testing ------- Unit test attached Thanks, Dhruba