> On 2011-10-06 23:37:24, Todd Lipcon wrote: > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java, > > line 28 > > <https://reviews.apache.org/r/2150/diff/2/?file=48551#file48551line28> > > > > perhaps should be abstract since it won't ever be instantiated? > > > > these functions are meant only for the server side, right? Otherwise > > they should all take an authority, and look at configs prefixed/suffixed > > with that authority? > > > > let me jump over to HDFS-2231 and try to review that first.. having a > > hard time following this.
Class has private constructor. I prefer that to abstract class. For some reason, I included HAUtil in this patch causing lot of confusion. It belongs to 2231. So I am attaching a patch without HAUtil changes. Also I will address rest of your HAUtil comments in 2231. - Suresh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2150/#review2422 ----------------------------------------------------------- On 2011-10-06 23:25:18, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2150/ > ----------------------------------------------------------- > > (Updated 2011-10-06 23:25:18) > > > Review request for hadoop-hdfs and Todd Lipcon. > > > Summary > ------- > > Uploading Suresh's patch to reviewboard > (https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from > 29/Sep/11 00:56) > > > This addresses bug HDFS-2301. > https://issues.apache.org/jira/browse/HDFS-2301 > > > Diffs > ----- > > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java > PRE-CREATION > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java > PRE-CREATION > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java > 1179521 > > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2150/diff > > > Testing > ------- > > > Thanks, > > Todd > >
