-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2247/
-----------------------------------------------------------
(Updated 2011-10-24 09:18:46.680787)
Review request for hadoop-hdfs.
Changes
-------
Added check for null on JournalAndStream#close
Summary
-------
A JournalManager may take hold of resources for the duration of their lifetime.
This isn't the case at the moment for FileJournalManager, but
BookKeeperJournalManager will, and it's conceivable that FileJournalManager
could take a lock on a directory etc.
This JIRA is to add Closeable to JournalManager so that these resources can be
cleaned up when FSEditLog is closed.
This addresses bug HDFS-2334.
http://issues.apache.org/jira/browse/HDFS-2334
Diffs (updated)
-----
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
aac2a35
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
8cfc975
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalManager.java
0bb7b0f
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
6976620
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalSet.java
0d6bc74
Diff: https://reviews.apache.org/r/2247/diff
Testing
-------
Thanks,
Ivan
