[ https://issues.apache.org/jira/browse/HDFS-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Agarwal resolved HDFS-5264. --------------------------------- Resolution: Won't Fix Punting - it will cause unnecessary code churn. > Consider renaming StorageID > --------------------------- > > Key: HDFS-5264 > URL: https://issues.apache.org/jira/browse/HDFS-5264 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Arpit Agarwal > > We should consider renaming StorageID to something else since we have changed > the meaning of the field. Previously it was used to identify the single > logical storage attached to a datanode and hence it was a de-facto identifier > for a Datanode. Now the StorageID identifies a single storage. To avoid > confusion of meaning especially when merging with other feature branches it > may be best to rename it to something else. > We can do so when merging phase 1 of the Heterogeneous Storage work into > trunk. > A partial list of places to update: > # FsVolumeSpi#storageID > # DatanodeStorageInfo#storageID > # DatanodeStorage#storageID > # StorageReceivedDeletedBlocks#storageID > # StorageReport#storageID > # LocatedBlock#storageIDs > # processFirstBlockReport > # DatanodeStorage#getStorageInfo > # TestDatanodeDescriptor#testBlocksCounter > # TestBlockManager.java > # FsDatasetSpi#getBlockReports -- This message was sent by Atlassian JIRA (v6.3.4#6332)