Lin Yiqun created HDFS-9951:
-------------------------------
Summary: Improve the Node key definition in
OfflineImageReconstructor
Key: HDFS-9951
URL: https://issues.apache.org/jira/browse/HDFS-9951
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Lin Yiqun
Assignee: Lin Yiqun
Priority: Minor
In class {{OfflineImageReconstructor}}, it uses many {{SectionProcessors}} to
process xml files and load the subtree of the XML into a Node structure. But
there are lots of places that node removes key by directively writing value in
methods rather than define them first. Like this:
{code}
Node expiration = directive.removeChild("expiration");
{code}
We could improve this to define them in Node and them invoked like this way:
{code}
Node expiration=directive.removeChild(Node.CACHE_MANAGER_SECTION_EXPIRATION);
{code}
And it will be good to manager node key's name in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
