Elek, Marton created HDFS-12588:
-----------------------------------

             Summary: Use GenericOptionsParser for scm and ksm daemon
                 Key: HDFS-12588
                 URL: https://issues.apache.org/jira/browse/HDFS-12588
             Project: Hadoop HDFS
          Issue Type: Sub-task
    Affects Versions: HDFS-7240
            Reporter: Elek, Marton
            Assignee: Elek, Marton


Most of the hadoop commands use the GenericOptionsParser to use some common CLI 
arguments (such as -conf or -D or -libjars to define configuration/modify 
configuration/modify classpath).

I suggest to use the same common options to scm and ksm daemons as well, as:

1. It allows to use the existing cluster management tools/scripts as the 
daemons could be configured in the same way as namenode and datanode
2. It follows the convention from the hadoop common.
3. It's easier to develop from the IDE (I start the ksm/scm/datanode/namenode 
from intellij but I need to add the configuration to the classpath. With -conf 
I would able to use external configration.)


I found one problem during the implementation. Until now we used `hdfs scm` 
command both for the daemon and the scm command line client. If there were no 
parameters the daemon is started, with parameters the cli is started. The help 
listed only the damon.

The -conf (GenericOptionParser) could be used only if we separate the scm and 
scmcli commands. But any way, it's a more clean and visible if we have 
separated `hdfs scm` and `hdfs scmcli`.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to