Dibyendu Karmakar created HDFS-13289:
----------------------------------------

             Summary: TestConnectionManager test case need correction
                 Key: HDFS-13289
                 URL: https://issues.apache.org/jira/browse/HDFS-13289
             Project: Hadoop HDFS
          Issue Type: Sub-task
            Reporter: Dibyendu Karmakar


In TestConnectionManager.testCleanup() 

 
{code:java}
// Make sure the number of connections doesn't go below minSize
ConnectionPool pool3 = new ConnectionPool(
conf, TEST_NN_ADDRESS, TEST_USER3, 2, 10);
addConnectionsToPool(pool3, 10, 0);
poolMap.put(new ConnectionPoolId(TEST_USER2, TEST_NN_ADDRESS), pool3);
connManager.cleanup(pool3);
checkPoolConnections(TEST_USER3, 2, 0);
{code}
this part need correction.

 

Here new ConnectionPoolId is created with TEST_USER2 but checkPoolConnections 
is done using TEST_USER3. 

In checkPoolConnections method 
{code:java}
if (e.getKey().getUgi() == ugi)
{code}
then only it will validate numOfConns and numOfActiveConns. In this case for 
TEST_USER3  ' *if*  'condition is returning *false* and if you pass any value 
to the checkPoolConnections method, the test case will pass.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to