Wei-Chiu Chuang created HDFS-14228: -------------------------------------- Summary: Incorrect getSnapshottableDirListing() javadoc Key: HDFS-14228 URL: https://issues.apache.org/jira/browse/HDFS-14228 Project: Hadoop HDFS Issue Type: Bug Components: snapshots Affects Versions: 2.1.0-beta Reporter: Wei-Chiu Chuang
The Javadoc for {{DistributedFileSystem#getSnapshottableDirListing()}} is not consistent with {{FSNamesystem#getSnapshottableDirListing()}} {code:title=ClientProtocol#getSnapshottableDirListing()} /** * Get listing of all the snapshottable directories. * * @return Information about all the current snapshottable directory * @throws IOException If an I/O error occurred */ @Idempotent @ReadOnly(isCoordinated = true) SnapshottableDirectoryStatus[] getSnapshottableDirListing() throws IOException; {code} {code:title=DistributedFileSystem#getSnapshottableDirListing()} /** * @return All the snapshottable directories * @throws IOException */ public SnapshottableDirectoryStatus[] getSnapshottableDirListing() {code} But the implementation at NameNode side is: {code:title=FSNamesystem#getSnapshottableDirListing()} /** * Get the list of snapshottable directories that are owned * by the current user. Return all the snapshottable directories if the * current user is a super user. * @return The list of all the current snapshottable directories * @throws IOException */ public SnapshottableDirectoryStatus[] getSnapshottableDirListing() {code} That is, if this method is called by a non-super user, it does not return all snapshottable directories. File this jira to get this corrected to avoid confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org