+1 Absolutely. It also makes it easy/clean for reviewers to leave specific comments and the authors can make incremental changes without the hassles of generating iterative patch files.
Thanks, Dinesh On Mon, Jul 22, 2019 at 2:06 PM Wei-Chiu Chuang <weic...@apache.org> wrote: > Historically, Hadoop developers create patches and attache them to JIRA, > andthen the Yetus bot runs precommit against the patch in the JIRA. > > The Github PR is more convenient for code review and less hassle for > committers to merge a commit. I am proposing for the community to prefer > Github PR over the traditional patch-in-jira. This doesn't mean we will > reject the traditional way, but we can move gradually to the new way. > Additionally, update the Hadoop "How to contribute" wiki, and advertise > that Github PR is the preferred method. > > Thoughts? >
